Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 4085: MegaMek fails to load Dropship sent from MekHQ #5255

Merged

Conversation

psikomonkie
Copy link
Collaborator

Fixes #4085

We don't actually track bay personnel. You can assign units to a dropship, but it doesn't change the nCrew for the ship, which MegaMek assumes will include bay personnel, so when loading a spaceship from MekHQ to MegaMek, it will calculate the current crew by taking nCrew and removing the assumed bay personnel - this is what prevents Spaceships from being moved form MHQ to MM, they will never have enough crew.

When spaceships are loaded from data, the crew includes the bay personnel, so the calculation passes.

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.49%. Comparing base (519101f) to head (8d8a54a).
Report is 48 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5255      +/-   ##
============================================
- Coverage     10.50%   10.49%   -0.01%     
+ Complexity     6044     6038       -6     
============================================
  Files           957      957              
  Lines        134716   134725       +9     
  Branches      19572    19577       +5     
============================================
- Hits          14149    14142       -7     
- Misses       119216   119232      +16     
  Partials       1351     1351              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit 5530d86 into MegaMek:master Nov 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MegaMek fails to load dropship sent from MekHQ
3 participants