Fixed Position of NewDayEvent Trigger in processNewDay
#5125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved `MekHQ.triggerEvent(new NewDayEvent(this))` to the end of `processNewDay` method. This refactor ensures the event trigger occurs after all day-start logic has been processed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5125 +/- ##
============================================
- Coverage 10.54% 10.53% -0.01%
- Complexity 6040 6042 +2
============================================
Files 956 956
Lines 134181 134213 +32
Branches 19481 19489 +8
============================================
+ Hits 14144 14145 +1
- Misses 118693 118719 +26
- Partials 1344 1349 +5 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved
MekHQ.triggerEvent(new NewDayEvent(this))to the end ofprocessNewDaymethod. This refactor ensures the event trigger occurs after all day-start logic has been processed.Closes #5119 && #5108 && #4297 (for real this time)