Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CamOps Contract Negotiation #5054

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

Algebro7
Copy link
Collaborator

@Algebro7 Algebro7 commented Oct 16, 2024

This implements the CamOps RAW Negotiation mechanics for the CamOps Contract Market. Players are allowed to reroll each term once, and the term is recalculated based on the MOS/MOF of an opposed negotiation check. For each 2 points of MOS/MOF, the roll on the supplemental terms table is adjusted up or down by 1.

I ended up adding some additional Camops-specific state in AtBContract. Specifically, the initial rolls for the contract so that they can later be adjusted if the terms are negotiated.

Flipping this to Draft since while writing I realized that we would need to serialize the initial rolls as well.

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.42%. Comparing base (4a9cce8) to head (f04a640).
Report is 42 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5054      +/-   ##
============================================
- Coverage     10.43%   10.42%   -0.02%     
+ Complexity     6032     6025       -7     
============================================
  Files           952      952              
  Lines        133878   133927      +49     
  Branches      19436    19443       +7     
============================================
- Hits          13976    13963      -13     
- Misses       118560   118620      +60     
- Partials       1342     1344       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Algebro7 Algebro7 marked this pull request as ready for review October 16, 2024 16:54
Copy link
Collaborator

@IllianiCBT IllianiCBT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Let's get this in the hands of the testers.

@HammerGS HammerGS merged commit 9c0c738 into MegaMek:master Oct 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants