-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colorise Skill Levels #5053
Colorise Skill Levels #5053
Conversation
…nto wvr-skill-colors
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5053 +/- ##
==========================================
Coverage 10.43% 10.44%
- Complexity 6032 6038 +6
==========================================
Files 952 952
Lines 133878 133986 +108
Branches 19436 19432 -4
==========================================
+ Hits 13976 13989 +13
- Misses 118560 118655 +95
Partials 1342 1342 ☔ View full report in Codecov by Sentry. |
So one point of feedback, before I review this properly: as a rule we use green to denote 'good' and red to denote 'bad'. While I see why you chose this scale, I think flipping the colors would be better. Purple for Elite is 10/10 though, let's keep that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of questions, but nothing that'll stop this from being merged. :)
For the colors, does this look good? @IllianiCBT |
Perfect! :) |
This started because I wanted a way to easily distinguish skill levels in Tech List of the Repair Panel:
This followed on to the repair section of the Warehouse:
And the refit selector:
And then on to non-techs, we have the Doctor List, which probably needs to be sorted by skill as well but who has that many doctors?
And then it was on to the rest of the places skill shows up in the program:
Of course, in the Personnel List, things can become a bit overboard with row highlights:
But in a week of playing with it, I didn't have a list nearly that bad and I don't think it works out too bad even if you do.
Of course, the colors are customizable. I believe these are reasonable defaults, though:
Along the way, I also cleaned up a fair bit of code to use StringBuilders, better HTML, better case statements, and
ReportingUtilities.messageSurroundedBySpanWithColor()
and such.