Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better visual distinction for GM mode / overtime toggles #5029

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Oct 11, 2024

Using MMToggleButton

image

@SJuliez SJuliez requested a review from IllianiCBT October 11, 2024 13:40
Copy link
Collaborator

@IllianiCBT IllianiCBT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.46%. Comparing base (6735093) to head (867b21b).
Report is 107 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5029      +/-   ##
============================================
- Coverage     10.46%   10.46%   -0.01%     
+ Complexity     6026     6020       -6     
============================================
  Files           950      950              
  Lines        133404   133437      +33     
  Branches      19383    19383              
============================================
- Hits          13967    13960       -7     
- Misses       118098   118130      +32     
- Partials       1339     1347       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit 1d989e9 into MegaMek:master Oct 11, 2024
4 checks passed
@repligator repligator added the GUI label Oct 15, 2024
@SJuliez SJuliez deleted the use-mmtogglebutton branch October 15, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants