Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin/sticky force view tab on TO&E panel #5025

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

WeaverThree
Copy link
Collaborator

Another tiny one but it will save me many many clicks. It makes the force view tab sticky, so if you're viewing a unit and select a different TO&E entry, it stays on unit. Or goes back there when its relevant.

There's probably a better way to do this like rearchitecturing the pane to not be recreated all the time and to just have two subpanels that get populated as needed, but this is the least invasive change I could come up with.

2024-10-10_191019

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.46%. Comparing base (4e72790) to head (6735093).
Report is 76 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5025      +/-   ##
============================================
- Coverage     10.47%   10.46%   -0.01%     
+ Complexity     6029     6026       -3     
============================================
  Files           950      950              
  Lines        133397   133404       +7     
  Branches      19384    19383       -1     
============================================
- Hits          13974    13967       -7     
- Misses       118076   118098      +22     
+ Partials       1347     1339       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@IllianiCBT IllianiCBT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine, but this is something I'd want tested before it gets merged.

@HammerGS
Copy link
Member

@IllianiCBT I'll let you decide when you want to merge this.

@IllianiCBT IllianiCBT merged commit b968322 into MegaMek:master Oct 11, 2024
4 checks passed
@WeaverThree WeaverThree deleted the wvr-toe-tab-pin branch October 16, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants