Refactored Daily Personnel Processing Logic. #4984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidated repeated code into private methods for better readability and maintainability. Updated `processNewDayPersonnel` to handle all personnel, avoiding potential `ConcurrentModificationExceptions`.
Added a check to return early in the processMonthlyIdleXP function if the person is not active.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4984 +/- ##
============================================
- Coverage 10.47% 10.46% -0.02%
- Complexity 6021 6022 +1
============================================
Files 951 951
Lines 133248 133345 +97
Branches 19377 19378 +1
============================================
- Hits 13961 13955 -6
- Misses 117940 118041 +101
- Partials 1347 1349 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidated code into private methods for better readability and maintainability. Updated
processNewDayPersonnelto handle all personnel, avoiding potentialConcurrentModificationExceptions.This doesn't just close the below case, but also fixes a number of issues stemming from the fact that we were only checking personnel events for characters with the 'active' personnel status. Characters who have departed the campaign (such as characters who have died, or resigned) are skipped.
Closes #4982