Prevent Battle Armor allocation in TORNADO_F4 wind scenarios #4934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Battle Armor units could be allocated to scenarios with TORNADO_F4 wind conditions where they cannot survive. This update adds a condition to exclude these units from being assigned in such scenarios, improving the realism and survivability of missions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4934 +/- ##
============================================
+ Coverage 10.42% 10.48% +0.05%
- Complexity 6003 6034 +31
============================================
Files 951 951
Lines 133139 133240 +101
Branches 19380 19380
============================================
+ Hits 13886 13976 +90
- Misses 117903 117920 +17
+ Partials 1350 1344 -6 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Oct 2, 2024
|
Conflicting files |
# Conflicts: # MekHQ/src/mekhq/campaign/mission/AtBDynamicScenarioFactory.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Battle Armor units could be allocated to scenarios with TORNADO_F4 wind conditions where they cannot survive. This update adds a condition to exclude these units from being assigned in such scenarios, improving the realism and survivability of missions.
Closes #4929