Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'Part Quality Report' Dialog #4888

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

IllianiCBT
Copy link
Collaborator

Implemented a dialog interface to generate and display a 'part quality report' for a single unit. This includes adding a new menu option, defining the necessary command, and creating the PartQualityReportDialog class for handling the report generation and display.

image

I imagine someone else can probably come in to make the report pretty, but I cannot stand GUI work so that person won't be me :D

Partially Closes #4773

Added color-coded messaging to ensure random death events are highly noticeable to users. Imported necessary utilities and refined new day processing to utilize the enhanced reporting mechanism.
Implemented a dialog interface to generate and display a 'part quality report' for a single unit. This includes adding a new menu option, defining the necessary command, and creating the `PartQualityReportDialog` class for handling the report generation and display.
@IllianiCBT IllianiCBT added GUI UX User experience labels Sep 25, 2024
@IllianiCBT IllianiCBT self-assigned this Sep 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.29%. Comparing base (2ef3222) to head (5173607).
Report is 50 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4888      +/-   ##
============================================
- Coverage     10.31%   10.29%   -0.02%     
+ Complexity     5872     5866       -6     
============================================
  Files           944      945       +1     
  Lines        131403   131468      +65     
  Branches      19064    19073       +9     
============================================
- Hits          13548    13533      -15     
- Misses       116539   116618      +79     
- Partials       1316     1317       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@HammerGS HammerGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work. Does need to look improvements

@HammerGS HammerGS merged commit 1341ebe into MegaMek:master Sep 25, 2024
4 checks passed
@IllianiCBT
Copy link
Collaborator Author

As much as I don't like GUI work and as much as I specifically said someone will need to do it...

... how would you like it appearing? If you have a specific design in mind I can see what we can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI UX User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: Maintenance/Supply tab in Hangar, and maybe ammo too.
3 participants