Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compliance Mech/Tech Fix. #4869

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Conversation

rjhancock
Copy link
Collaborator

Fixed names for recently re-added portraits due to .gitignore issue.
Adjusted .gitignore to NOT ignore portraits.

Should we move the other Tech's to Tek's?

@IllianiCBT
Copy link
Collaborator

Ahhh, sorry Tex, I missed that the portrait file names included prohibited terms. My bad.

@rjhancock
Copy link
Collaborator Author

Nah, all good. It happens. The .gitignore is how they got missed initially as I did do the name change but it stopped the adding which is why I removed it in this PR and re-added/fixed them.

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.30%. Comparing base (752cc96) to head (b1bfac5).
Report is 19 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4869      +/-   ##
============================================
- Coverage     10.30%   10.30%   -0.01%     
+ Complexity     5871     5870       -1     
============================================
  Files           944      944              
  Lines        131394   131403       +9     
  Branches      19063    19064       +1     
============================================
  Hits          13545    13545              
- Misses       116532   116540       +8     
- Partials       1317     1318       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjhancock rjhancock merged commit 0a12881 into MegaMek:master Sep 21, 2024
3 checks passed
@rjhancock rjhancock deleted the portrait-mech-fix branch September 21, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants