Fixed Hidden Loyalty Calculation in RetirementDefectionTracker #4819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the loyalty calculation (when loyalty is hidden) by adding a bonus for commanders and applying a loyalty modifier based on the adjusted loyalty score, instead of using raw loyalty score.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4819 +/- ##
============================================
- Coverage 10.61% 9.92% -0.69%
+ Complexity 5655 5645 -10
============================================
Files 948 948
Lines 132553 132556 +3
Branches 19048 19048
============================================
- Hits 14072 13158 -914
- Misses 117246 118163 +917
Partials 1235 1235 ☔ View full report in Codecov by Sentry. |
# Conflicts: # MekHQ/src/mekhq/campaign/personnel/turnoverAndRetention/RetirementDefectionTracker.java
|
Updated to account for the recent name change project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the loyalty calculation (when loyalty is hidden) by adding a bonus for commanders and applying a loyalty modifier based on the adjusted loyalty score, instead of using raw loyalty score.
Closes #4783