Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include more information about available personnel in Camops Personnel Market Refresh Report #4777

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

Algebro7
Copy link
Collaborator

@Algebro7 Algebro7 commented Sep 3, 2024

This adds a small amount of information about new personnel in the market refresh report when the CamOps market is being used. I decided to only do this for CamOps as it generates a single unit per day and thus won't flood the report with messages for "higher yield" methods.

This change was in response to player feedback in Discord that it was tedious to check the personnel market every day to see what was available. The intention here is to show the player at a glance the important information (exp level and role, mainly) so they can skip checking the market if they aren't interested.

Here's what the report looks like:

camops-market-report

@IllianiCBT
Copy link
Collaborator

This looks like it has a failing test; you likely need to update the branch to current in mhq, mm, and mml. Just clicking the 'update branch' button will only update the branch to master on mhq.

@Algebro7 Algebro7 force-pushed the camops-personnel-market-report branch from 388026b to 8885559 Compare September 6, 2024 20:17
@Algebro7
Copy link
Collaborator Author

Algebro7 commented Sep 6, 2024

Thanks, looked like some weird intermittent error. Rebased and tests passed this time.

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.80%. Comparing base (4fa9b72) to head (dcd7473).
Report is 117 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4777      +/-   ##
============================================
+ Coverage     10.68%   10.80%   +0.12%     
- Complexity     5710     5716       +6     
============================================
  Files           950      950              
  Lines        131302   131321      +19     
  Branches      19135    19140       +5     
============================================
+ Hits          14025    14195     +170     
+ Misses       116052   115900     -152     
- Partials       1225     1226       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Algebro7 Algebro7 force-pushed the camops-personnel-market-report branch from 8885559 to dcd7473 Compare September 8, 2024 19:03
@IllianiCBT IllianiCBT merged commit a998c78 into MegaMek:master Sep 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants