Updated Prisoner Resolution Messages #4497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed messages that prompted loyalty changes when prisoners were freed, executed, or jettisoned, and eliminated execution rolls calculation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4497 +/- ##
=========================================
Coverage 10.31% 10.31%
Complexity 5813 5813
=========================================
Files 934 934
Lines 128441 128440 -1
Branches 18910 18909 -1
=========================================
Hits 13253 13253
+ Misses 113912 113911 -1
Partials 1276 1276 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Aug 1, 2024
This was referenced Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the prisoner resolution messages to correct a couple of formatting typos that resulted in an NPE when resolving prisoners.
I also went ahead and removed some vestigial messages relating to loyalty change resulting from prisoner resolutions, as these are not in use.
Closes #4496