Updated Salvage Terminology #4465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code in various MekHQ modules was refactored to chang the terminology from "Salvage" to "Strip" or "Irreparable" as appropriate for better clarification in the game's context.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4465 +/- ##
=========================================
Coverage 10.24% 10.24%
Complexity 5809 5809
=========================================
Files 925 925
Lines 126456 126456
Branches 18770 18770
=========================================
Hits 12953 12953
Misses 112228 112228
Partials 1275 1275 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Jul 23, 2024
HammerGS
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed instances of "salvage" in the context of 'Repair Status' to "strip", to better match its' purpose.
Changed "salvage" to "irreparable" during the scenario resolution dialogue, to better match its' intended meaning.
This helps reduce the number of ambiguous usages of the term 'salvage' and will help reduce confusion.
I also did a little light refactoring in the files these changes were made.
Closes #4450