Removed 'durationWeeks' Text from Education Tooltip #4411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'durationWeeks' text was removed from the Education properties and the corresponding code in the Academy.java class was updated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4411 +/- ##
=========================================
Coverage 10.26% 10.26%
Complexity 5809 5809
=========================================
Files 924 924
Lines 126223 126221 -2
Branches 18698 18697 -1
=========================================
Hits 12952 12952
+ Misses 111996 111994 -2
Partials 1275 1275 ☔ View full report in Codecov by Sentry. |
HoneySkull
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'durationWeeks' text was removed from the Education properties and the corresponding code in the Academy.java class was updated. Now the education tooltip will always show qualification duration in days. This decision was based on Discord feedback.