Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Dialog for Zero Award-Eligible Personnel #4402

Merged
merged 2 commits into from
Jul 14, 2024

Conversation

IllianiCBT
Copy link
Collaborator

A dialog informing that no one is eligible for an award has been added to the auto-awards feature. This dialog box appears when the auto-award process is manually triggered and finds that there are no personnel eligible for any awards. Previously, the autoAwards dialog would silently run, leading users to believe the function was broken.

A dialog informing that no one is eligible for an award has been added to the auto-awards feature. This dialog box appears when the auto-award process is manually triggered and finds that there are no personnel eligible for any awards.
@IllianiCBT IllianiCBT added Awards GUI UX User experience labels Jul 13, 2024
@IllianiCBT IllianiCBT self-assigned this Jul 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.27%. Comparing base (f7bd31c) to head (7fe2b0f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4402      +/-   ##
============================================
- Coverage     10.27%   10.27%   -0.01%     
  Complexity     5811     5811              
============================================
  Files           925      925              
  Lines        126031   126042      +11     
  Branches      18627    18628       +1     
============================================
  Hits          12945    12945              
- Misses       111811   111822      +11     
  Partials       1275     1275              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT IllianiCBT merged commit 5b457d2 into MegaMek:master Jul 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awards GUI UX User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants