Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Prisoner Defection Calculation to Optionally Include Loyalty #4394

Merged
merged 2 commits into from
Jul 14, 2024

Conversation

IllianiCBT
Copy link
Collaborator

The defection computation now considers the individual's loyalty modifier (if enabled), expanding the factors considered in determining if a prisoner defects.

The defection calculation is as follows:
8 + enemy unit rating - campaign unit rating + loyalty modifier

Loyalty modifier is only used if loyalty modifiers are enabled in campaign options.

The defection computation now considers loyalty modifier (if enabled), expanding the factors considered in determining if a prisoner defects.
@IllianiCBT IllianiCBT self-assigned this Jul 13, 2024
@IllianiCBT IllianiCBT added the Personnel Personnel-related Issues label Jul 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.27%. Comparing base (f7bd31c) to head (69b3a88).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4394   +/-   ##
=========================================
  Coverage     10.27%   10.27%           
  Complexity     5811     5811           
=========================================
  Files           925      925           
  Lines        126031   126029    -2     
  Branches      18627    18628    +1     
=========================================
  Hits          12945    12945           
+ Misses       111811   111809    -2     
  Partials       1275     1275           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT IllianiCBT merged commit 96a6659 into MegaMek:master Jul 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Personnel Personnel-related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants