Updated Scenario Modifiers to More Consistently Contribute to Map Size #4136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SJuliez
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the title, this is a relatively small PR that goes through and updates our scenario modifiers to more consistently contribute to map size. The logic I followed is that if a modifier adds units to the battle, and those units are not off-board (i.e. off-board artillery), then the units from that modifier should contribute to map size.
The main beneficiaries of this PR will be ASF, as larger maps will allow players to keep their ASF elements on-board longer.
Closes
Potentially closes #1637.
While I don't think the small amount of map size increase offered by this PR precisely addresses what the user is requesting, I think this is a better solution. Increasing map size more uniformly, without over-inflating map size just because ASF is present.