Use tabs in customize scenario dialog #4106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sleet01
reviewed
May 25, 2024
| BorderFactory.createTitledBorder(resourceMap.getString("panOtherForces.title")))); | ||
| panOtherForces.setPreferredSize(new Dimension(600,250)); | ||
| panOtherForces.setMinimumSize(new Dimension(600,250)); | ||
| panOtherForces.setPreferredSize(new Dimension(600,300)); |
There was a problem hiding this comment.
I think we'd talked previously about making the MekHQ UI more responsive; would it be possible to use a persistent size, or a % of screen size, or something other than magic numbers here?
There was a problem hiding this comment.
Looks like it already got merged, but I can think about the issue in future dialog stuff.
Sleet01
approved these changes
May 25, 2024
HammerGS
added a commit
that referenced
this pull request
May 25, 2024
MegaMek + Fix 5476: Update SV armor slots to 2 or 1 for Rating E or F respectively MegaMekLab + Fix ##1514: Fix Atrocious table shading render speed MekHQ + PR #4106: Use tabs in customize scenario dialog + PR #4105: Updated Post-Scenario Logging for Prisoners + PR #4104: Fixed Post-Scenario Tracking System's Handling of Multiple Personnel in autoAwards + PR #4102: Fixed Award Tier Count Calculations in PersonViewPanel + PR #4093: Added Negotiation and Scrounge Skill Settings for Administrator Personnel + PR #4054: Added Life Paths Campaign Options Tab, Added Education Module Very Important to read the documentation on this feature (See Docs folder)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new CustomizeScenarioDialog was quite large which can cause problems on small monitors. So, I redid the layout using tabs to make the overall dialog smaller, as shown in the attached images.
I also fixed a small problem on CustomizeScenarioObjectivesDialog where I was using the wrong label.