Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Untreated Personnel Nag Triggering for Prisoners. #4003

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

IllianiCBT
Copy link
Collaborator

@IllianiCBT IllianiCBT commented Apr 16, 2024

Current Implementation

The Untreated Personnel Nag Dialog triggers whenever users are attempting to Advance Day with untreated personnel

Problem

This can get very spammy when there are large numbers of prisoners and insufficient doctors. This was an oversight in my original code.

Solution

The nag no longer triggers for injured Prisoners.

Closes #4001

@IllianiCBT IllianiCBT self-assigned this Apr 16, 2024
@IllianiCBT IllianiCBT added Bug Personnel Personnel-related Issues GUI labels Apr 16, 2024
Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Sleet01 Sleet01 merged commit 1e819bf into MegaMek:master Apr 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug GUI Personnel Personnel-related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: 49.19 - Option for Untreated Person Nag to ignore ignore prisoners.
2 participants