Unmaintained Unit Nag Dialog Suppressed for Units set to Salvage #3943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3943 +/- ##
============================================
- Coverage 10.65% 10.65% -0.01%
- Complexity 5528 5530 +2
============================================
Files 836 838 +2
Lines 114275 114323 +48
Branches 17185 17195 +10
============================================
+ Hits 12176 12178 +2
- Misses 100871 100917 +46
Partials 1228 1228 ☔ View full report in Codecov by Sentry. |
Sleet01
approved these changes
Apr 3, 2024
|
Looks good. |
AaronGullickson
approved these changes
Apr 3, 2024
MekHQ/src/mekhq/gui/dialog/nagDialogs/UnmaintainedUnitsNagDialog.java
Outdated
Show resolved
Hide resolved
HammerGS
added a commit
that referenced
this pull request
Apr 6, 2024
+ PR #3922: Add missing cockpit costs and weights + PR #3944: Added Nag Dialog for Pregnant Combatants + Fix #3943: Unmaintained Unit Nag Dialog Suppressed for Units set to Salvage + PR #3933: Fixes for #3729,#3817,#3753: Clamped Unit Rating Mod for CamOps (redux) + PR #3923: Hide Toughness When 0 + PR #3915: Added Dialog to Confirm New Campaign (redux) + PR #3908: Adjusted Default Tech Counts + PR #3967: Adjusted Zoom Speed on Interstellar Map Panel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Implementation
When users trigger
Advance Day, while there are unmaintained units in their hanger, they are presented with a nag dialog asking for confirmation.Problem
This triggers even for units set to salvage.
Solution
The nag now only triggers if there are unmaintained units that are not set to salvage.
Closes
Closes #646 (only 6 years old! :D)