Fix 3882: update Aerospace handling and reporting in MHQ #3925
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix cleans up the last extraneous UnitType.AERO case and comparison locations, excepting one or two that look to be useful for backward compatibility.
This will alleviate the issue seen in #3882 where ASF units are not properly accounted for in the Unit Rating Report, as well as preventing generation of new missions containing ASF forces as "ground" units (although existing missions in save files will not be affected).
Testing:
Note: testing for this fix uncovered further issues in the RandomUnitGenerator and RATManager when dealing with ASFs; those will be fixed in a separate MM-only PR.
Close #3882