Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3882: update Aerospace handling and reporting in MHQ #3925

Merged

Conversation

Sleet01
Copy link
Collaborator

@Sleet01 Sleet01 commented Mar 29, 2024

This fix cleans up the last extraneous UnitType.AERO case and comparison locations, excepting one or two that look to be useful for backward compatibility.

This will alleviate the issue seen in #3882 where ASF units are not properly accounted for in the Unit Rating Report, as well as preventing generation of new missions containing ASF forces as "ground" units (although existing missions in save files will not be affected).

Testing:

  1. ran all three projects' unit tests,
  2. updated failing MHQ unit tests to mock AeroSpaceFighter class instances instead of bare Aero instances.
  3. ran the previously-failing Unit Rating report with saves provided by @Thom293 for issue [49.19 Nightly] ASF units are not being tracked correctly by MHQ/StratCon #3882.

Note: testing for this fix uncovered further issues in the RandomUnitGenerator and RATManager when dealing with ASFs; those will be fixed in a separate MM-only PR.

Close #3882

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.66%. Comparing base (2676968) to head (eb7518d).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3925   +/-   ##
=========================================
  Coverage     10.65%   10.66%           
- Complexity     5528     5534    +6     
=========================================
  Files           836      836           
  Lines        114275   114276    +1     
  Branches      17185    17184    -1     
=========================================
+ Hits          12176    12184    +8     
+ Misses       100871   100862    -9     
- Partials       1228     1230    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sleet01
Copy link
Collaborator Author

Sleet01 commented Mar 30, 2024

With the Force Generator changes this PR looks really big, but everything under data/forcegenerator/ is just replacing 'Aero' with 'AeroSpaceFighter'.

@Sleet01 Sleet01 requested a review from NickAragua March 30, 2024 08:00
@Sleet01 Sleet01 merged commit e323190 into MegaMek:master Apr 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[49.19 Nightly] ASF units are not being tracked correctly by MHQ/StratCon
2 participants