Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [Company Generator] Correct Starting Cash Dice Count #3895

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

IllianiCBT
Copy link
Collaborator

The tooltip for starting cash dice count states that the base value of 18 dice is enough for a company. However, the default dice count is 17, not 18.

image

This patch changes default starting cash dice count from 17 to 18.

I opted to change the default dice count, and not the tooltip, as 18 is easily divided by 3 for players who wish to base their starting funds on their initial lance count. i.e. 6 dice per lance.

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 10.64%. Comparing base (fbbf4d8) to head (e5ac412).

Files Patch % Lines
...se/companyGeneration/CompanyGenerationOptions.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3895   +/-   ##
=========================================
  Coverage     10.64%   10.64%           
  Complexity     5487     5487           
=========================================
  Files           834      834           
  Lines        113856   113856           
  Branches      17193    17193           
=========================================
  Hits          12119    12119           
  Misses       100528   100528           
  Partials       1209     1209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit 96dec7f into MegaMek:master Mar 24, 2024
5 of 6 checks passed
HammerGS added a commit that referenced this pull request Mar 24, 2024
+ Fix #2990: Stratcon draw counts as loss
+ PR #3895: Correct Starting Cash Dice Count in Company Generator
+ PR #3900: Disconnect quietly from GameThread for MekHQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants