StratCon Mapgen Fix #3874
Merged
StratCon Mapgen Fix #3874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h them I set maximum CF of 200 on some base maps, which is illegal, and was throwing errors in map generation. It was also preventing some of the Facilities from generating in Stratcon. The Cold, Desert and Jungle bases also had their density wrong, which I fixed, and I renamed the prior versions as "Rural Homesteads" and added them to the appropriate spot in the StratconBiomeManifest.xml.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3874 +/- ##
=========================================
Coverage 10.62% 10.62%
Complexity 5472 5472
=========================================
Files 834 834
Lines 113887 113887
Branches 17201 17201
=========================================
Hits 12097 12097
Misses 100582 100582
Partials 1208 1208 ☔ View full report in Codecov by Sentry. |
HammerGS
added a commit
that referenced
this pull request
Mar 13, 2024
+ Fix: #3848: Unable to assign Aerospace units to a transport in the TO&E + Fix: #3856: Display bug in 'Basic Unit Information', doesn't show aerospace units + Fix: #3815: StratCon Modifier BadEvent is broken and doesnt do anything + PR: #3874: Fixes MegaMek #4464 - StratCon Mapgen Fix + PR: #3866: Fixed Typo and Removed Indents + Data: #3865: 499 new callsigns + PR: #3878: Interstellar Map Hiring Hall Highlight
IllianiCBT
pushed a commit
to IllianiCBT/mekhq
that referenced
this pull request
Mar 18, 2024
+ Fix: MegaMek#3848: Unable to assign Aerospace units to a transport in the TO&E + Fix: MegaMek#3856: Display bug in 'Basic Unit Information', doesn't show aerospace units + Fix: MegaMek#3815: StratCon Modifier BadEvent is broken and doesnt do anything + PR: MegaMek#3874: Fixes MegaMek MegaMek#4464 - StratCon Mapgen Fix + PR: MegaMek#3866: Fixed Typo and Removed Indents + Data: MegaMek#3865: 499 new callsigns + PR: MegaMek#3878: Interstellar Map Hiring Hall Highlight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some StratCon mapgen settings that I messed up when submitting them. When I was assisting with them I set maximum CF of 200 on some base maps, which is illegal, and was throwing errors in map generation. Town size was also set to zero which also threw an error. It was also preventing some of the Facilities from generating in Stratcon.
Also, the Cold, Desert and Jungle bases also had their density wrong, which I fixed, and I renamed the prior versions as "Rural Homesteads" and added them to the appropriate spot in the StratconBiomeManifest.xml.
These changes are related to MHQ StratCon, but should fix MM bug: 4464
MegaMek/megamek#4464
Screens as examples for the cold base, but same changes were made to hot and jungle.
Old Base Cold (now renamed as Rural Homesteads Cold):
Fixed Base Cold:
