-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manually set TO&E force commander #3772
manually set TO&E force commander #3772
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One improvement, otherwise this looks god
Co-authored-by: Justin Bowen <39067288+Windchild292@users.noreply.github.com>
I've committed the suggestion which seemed valid. Hope I didnt destroy anything. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3772 +/- ##
============================================
- Coverage 10.63% 10.62% -0.01%
+ Complexity 5473 5472 -1
============================================
Files 834 834
Lines 113770 113854 +84
Branches 17196 17203 +7
============================================
+ Hits 12099 12101 +2
- Misses 100465 100546 +81
- Partials 1206 1207 +1 ☔ View full report in Codecov by Sentry. |
Still waiting on uploaded save from bug report |
Did you mean mine? Sorry did you need something else? |
Going to hold of merging until @NickAragua confirms its good to go. |
…m/NickAragua/MekHQ into manual_force_commander_assignment
Sorry I missed the fix posted earlier. Tested it just now. Seems to work great. If someone set as commander is moved from a lance, their command flag is wiped and the next highest rank is then listed as commander. Can select any equals as commander, move them, and it causes no more issues. Looks good to me. You or anyone is welcome to ping me on discord. wont bother me at all. Sorry I missed. |
Implements #3540 by allowing the manual selection of a force commander from the TO&E menu if there's more than one "highest rank". Automatically updates the force commander if a unit/person is added/removed from the force/campaign.