-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AbstractIcon: Force Icon Rework #2946
AbstractIcon: Force Icon Rework #2946
Conversation
…tribution is part of the MekHQ Extras instead
…ator be determined on a new day
Codecov Report
@@ Coverage Diff @@
## master #2946 +/- ##
============================================
- Coverage 10.78% 10.22% -0.56%
- Complexity 4030 4045 +15
============================================
Files 758 773 +15
Lines 102144 107928 +5784
Branches 16728 16767 +39
============================================
+ Hits 11013 11038 +25
- Misses 89752 95515 +5763
+ Partials 1379 1375 -4
Continue to review full report at Codecov.
|
Kinda like to see this one in for 49.6. But I can't even filter to see the changed code. It crashes Chrome for me. How about two separate PR's one for the data stuff and one for the code. Otherwise I think this will never happen. |
I'd have separated the two if they weren't mutually required. As for GitHub's handling... that's annoyingly bad code on their end. |
Bottom line is, there is no way to meaningfully review the code changes. Feel free to spin out a separate PR with just the code changes for review purposes only. |
I've opened #3014, which is just the code for this PR. |
This PR moves Force Icons to Abstract Icon, and divides them into three separate types. These are StandardForceIcon, LayeredForceIcon, and UnitIcon, all of which have differing functionality. Additionally, this adds LayeredForceIcon export to png, force icon TO&E icon copy/paste, and automated new day force icon operational status updates (based on a MekHQ option).
This PR also replaces the Force Icon images with the far more comprehensive and standardized Kailan pack, with full migration from the old setup and a new MekHQ extras repository containing the current pack and a pack of standard force icons created by Mjolnir06.
The full list of what this does, which I used to keep this organized:
For reviewers:
This file is large because of the ~7k lines of migration, and almost all of the file differences are because of the Force Icon pack swapover. Code-wise most of the work is on the dialog-side, to get the three icon types (with the fourth, internal type used in LayeredForceIcon) selectable and usable.