Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1723: Fixing Missing Personnel and Hangar Tab Selection Highlights #2148

Merged
merged 6 commits into from
Oct 16, 2020

Conversation

Windchild292
Copy link
Contributor

This fixes #1723. The first four commits are code cleanup and refactoring, the fifth adds the force icon for the graphical hangar display, and the sixth is the bugfix.

Copy link
Contributor

@sixlettervariables sixlettervariables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question.

setForeground(UIManager.getColor("Table.foreground"));
setBackground(UIManager.getColor("Table.background"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this order matter and others do not seem to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't, I removed it as part of my testing and put it back in a different order... and didn't consider it worth a commit to swap back.

@Windchild292 Windchild292 merged commit 4e6d5f0 into MegaMek:master Oct 16, 2020
@Windchild292 Windchild292 deleted the dev_Windchild_1723 branch October 16, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.47.6 Nimbus theme missing selection highlights
2 participants