Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardizing MRMS Options #2077

Merged
merged 5 commits into from
Oct 3, 2020
Merged

Standardizing MRMS Options #2077

merged 5 commits into from
Oct 3, 2020

Conversation

Windchild292
Copy link
Contributor

This standardizes MRMS into immediately using MassRepairConfiguredOptions. This is required for a few future MRMS stories.

@Windchild292 Windchild292 self-assigned this Sep 30, 2020
sixlettervariables
sixlettervariables approved these changes Oct 3, 2020
View reviewed changes
Copy link
Contributor

@sixlettervariables sixlettervariables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two quick comments, but nothing holding this up.

MekHQ/src/mekhq/service/MassRepairConfiguredOptions.java Outdated Show resolved Hide resolved
MekHQ/src/mekhq/service/MassRepairOption.java Outdated Show resolved Hide resolved
@Windchild292 Windchild292 merged commit 26f6d5d into MegaMek:master Oct 3, 2020
@Windchild292 Windchild292 deleted the dev_Windchild_MRMSOptions branch October 3, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sixlettervariables sixlettervariables sixlettervariables approved these changes

Assignees

@Windchild292 Windchild292

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Windchild292 @sixlettervariables