Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Campaign writeToXml: Fixing Output Spacing Issues #1896

Merged

Conversation

Windchild292
Copy link
Contributor

This implements the MekHqXmlUtil functions fully in writeToXML and implements indent based on a constant value instead of being specified numbers

The offsets have been annoying me for a while, so I've fixed them here.

Review with whitespace differences off, as I fixed what was left of the primary formatting issues.

@Windchild292 Windchild292 self-assigned this Aug 3, 2020
Copy link
Member

@NickAragua NickAragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's hold it until after the "hotfix".

@Windchild292 Windchild292 merged commit 55ad8df into MegaMek:master Aug 8, 2020
@Windchild292 Windchild292 deleted the dev_Windchild_CampaignWriteToXML branch August 8, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants