Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Menu Bar Mnemonics (Shortcut Keys) #1583

Merged
merged 24 commits into from
Mar 28, 2020
Merged

Adding Menu Bar Mnemonics (Shortcut Keys) #1583

merged 24 commits into from
Mar 28, 2020

Conversation

Windchild292
Copy link
Contributor

I'd recommend reviewing the March 19th Commits together, then the refactoring commit, then the remaining commits can be reviewed in any order.

@Windchild292
Adding mnemonics to the file dropdown menu
8d08565
@Windchild292
Switching location of comments talking about the Mnemonics for a menu
8688b9c
@Windchild292
Adding the menu mnemonics
2507eb6
@Windchild292
Adding more mnemonics to the top bar
6a615ef
@Windchild292
Fixing bug where I double assigned the same mnemonic
2bd671d
@Windchild292
Fixing copy-paste issues for mnemonics
4794a51
@Windchild292
Adding mnemonic to the help tab
78770f5
@Windchild292
Adding mnemonics to the view tab
9a289df
@Windchild292
Adding View menu mnemonics
5e29421
@Windchild292
Adding Help tab mnemonics
bca30a7
@Windchild292
Adding mnemonics to the manage campaign menu
20a75b3
@Windchild292
Adding Marketplace Mnemonics
f1684d9
@Windchild292
Switching bulk release Astechs to instead use R as the mnemonic
4c95e6e
@Windchild292
Renaming Menu items and switching mnemonics to fit the renamed dialogs
8bcc933
@Windchild292
Renaming two roles to improve the naming on the Menu bar
21e8b3e
@Windchild292
Refactoring if statements and reordering to properly display menu items
c0bd6d9
@Windchild292
Adding role mnemonics to Person
cee40ef
@Windchild292
Fixing localization in the about menu
1ab907c
@Windchild292
Merge remote-tracking branch 'upstream/master' into dev_Windchild_Mne…
885fe58 
…monics
@Windchild292 Windchild292 mentioned this pull request Mar 20, 2020
Closed
sixlettervariables
sixlettervariables reviewed Mar 28, 2020
View reviewed changes
Copy link
Contributor

@sixlettervariables sixlettervariables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about a comment. Presume for now that you can never change being a host or client. I'll handle toggling or setting up the eventing for that.

MekHQ/src/mekhq/campaign/CampaignController.java Outdated Show resolved Hide resolved
@sixlettervariables sixlettervariables merged commit c06eb6c into MegaMek:master Mar 28, 2020
@Windchild292 Windchild292 deleted the dev_Windchild_Mnemonics branch March 28, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickAragua NickAragua NickAragua left review comments

@sixlettervariables sixlettervariables sixlettervariables approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Windchild292 @sixlettervariables @NickAragua