Add customization for colors used throughout MekHQ #1480 #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts and fixes 1 when merging c997c91 into d1c4c5f - view on LGTM.com new alerts:
fixed alerts:
|
|
|
||
| @Override | ||
| protected void dispose() { | ||
| // TODO Auto-generated method stub |
There was a problem hiding this comment.
Unlikely.
|
This pull request fixes 1 alert when merging fc48f6a into d1c4c5f - view on LGTM.com fixed alerts:
|
NickAragua
approved these changes
Feb 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows customization (without a UX at the moment) for colors throughout MekHQ, providing the backend work to #1480. Each property has a main and alternate color, currently used for backgrounds and foregrounds respectively. The values are saved in
mmconf/mekhq.preferencesas a pair of colors separated by a pipe, e.g.#ff0000|#000000. Each of the colors provides a default value based on our original colors.