Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Planetary Acquisition can infinite loop under certain conditions #1447

Closed
sixlettervariables opened this issue Feb 2, 2020 · 3 comments · Fixed by #1451
Closed

Planetary Acquisition can infinite loop under certain conditions #1447

sixlettervariables opened this issue Feb 2, 2020 · 3 comments · Fixed by #1451

Comments

@sixlettervariables
Copy link
Contributor

Updated information: It appears an issue with Planetary acquisition in Campaign Options is the root of this bug. While solved on a short term basis, leaving this for future attempts to resolve the underlying problem for others. (Turning Planetary acquisition off solved all the problems, my suspicion is it's related to purchasing in general, but I'm not a coder anymore, and I have no clue.)

Edit note: Other issue about internal to MHQ MML in unoffical tech level not showing battlearmor bays in Transport bays remains.

Originally posted by @MageOhki in #1444 (comment)
sixlettervariables added a commit to sixlettervariables/mekhq that referenced this issue Feb 2, 2020
@sixlettervariables
Don't infinite loop in planetary acquisition MegaMek#1447
a5f51c1
@sixlettervariables sixlettervariables mentioned this issue Feb 2, 2020
Merged
@servo01
Copy link

servo01 commented Feb 2, 2020

ANY part acquisition roll is causing my fresh install of 47.3 to lock completely. - Even with planetary acquisition turned off.

sixlettervariables added a commit to sixlettervariables/mekhq that referenced this issue Feb 2, 2020
@sixlettervariables
Fix same bug in goShoppingStandard MegaMek#1447
275f0fe
@sixlettervariables
Copy link
Contributor Author

Fixed that as well @servo01, thanks for the heads up.

sixlettervariables added a commit that referenced this issue Feb 3, 2020
@sixlettervariables
Merge pull request #1448 from sixlettervariables/bug-1447-planetary-a…
91783f0 
…cquisition-infinite-loop

Bug: Don't infinite loop in acquisition logic #1447
@sixlettervariables
Copy link
Contributor Author

Fixed in #1448.

sixlettervariables added a commit to sixlettervariables/mekhq that referenced this issue Feb 4, 2020
@sixlettervariables
Refine shopping to never indefinitely loop MegaMek#1447
2893c19
@sixlettervariables sixlettervariables mentioned this issue Feb 4, 2020
Merged
sixlettervariables added a commit that referenced this issue Feb 6, 2020
@sixlettervariables
Merge pull request #1451 from sixlettervariables/continue-to-refine-a…
cce74f9 
…cquisitions

Refine shopping to avoid indefinitely loops #1447
@AaronGullickson AaronGullickson mentioned this issue May 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refine shopping to avoid indefinitely loops #1447 sixlettervariables/mekhq
2 participants
@sixlettervariables @servo01