Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6259 error spam and deployment hang with combined arms forces #6292

Conversation

Sleet01
Copy link
Collaborator

@Sleet01 Sleet01 commented Dec 19, 2024

This clears up some error spam and Exceptions reported in #6259. Also fixed a log line that was not getting formatted correctly.

Hopefully also prevents hung games on rare occasions where the deployment hex scoring process and/or path-generating process could result in a null return value, possibly hanging the game (I was not able to reproduce this error after making these changes).

Of note, changes previously made to prevent ConcurrentModificationException errors had to be reinforced with explicit synchronized(modes) blocks, possibly due to more checks introduced via the Pulse Module updates. Keep this approach in mind for similar issues seen due to iterator usage causing fail-fast errors.

Testing:

  1. ran mission from issue dozens of times.
  2. ran all projects' unit tests.

Close #6259

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.95%. Comparing base (ba6cfe2) to head (5bcc422).
Report is 8 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6292      +/-   ##
============================================
- Coverage     28.95%   28.95%   -0.01%     
+ Complexity    14018    14016       -2     
============================================
  Files          2672     2672              
  Lines        269229   269237       +8     
  Branches      47911    47913       +2     
============================================
- Hits          77953    77950       -3     
- Misses       187376   187387      +11     
  Partials       3900     3900              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sleet01 Sleet01 merged commit 953fc5b into MegaMek:master Dec 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants