Fix #6259 error spam and deployment hang with combined arms forces #6292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clears up some error spam and Exceptions reported in #6259. Also fixed a log line that was not getting formatted correctly.
Hopefully also prevents hung games on rare occasions where the deployment hex scoring process and/or path-generating process could result in a null return value, possibly hanging the game (I was not able to reproduce this error after making these changes).
Of note, changes previously made to prevent
ConcurrentModificationException
errors had to be reinforced with explicitsynchronized(modes)
blocks, possibly due to more checks introduced via the Pulse Module updates. Keep this approach in mind for similar issues seen due to iterator usage causing fail-fast errors.Testing:
Close #6259