Implement RISC laser pulse module #6209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neoancient
commented
Nov 19, 2024
| @@ -502,7 +502,7 @@ public boolean isSpreadable() { | |||
| return spreadable; | |||
| } | |||
|
|
|||
| public int getToHitModifier() { | |||
| public int getToHitModifier(@Nullable Mounted<?> mounted) { | |||
There was a problem hiding this comment.
There are some cases (particularly in AlphaStrike and BattleForce conversion code) where the Mounted is not available. In those cases a null is passed, which skips the check for the laser pulse module.
HammerGS
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required changes to method signatures of EquipmentType::getToHitModifier and EquipmentType::getModesCount. getToHitModifier needs to know the weapon's mode and getModesCount needs to know whether the mount is linked by a laser pulse module. I added a getToHitModifier with no parameters to AmmoType (which is the old signature) to reduce the number of changes to the code.