Make EntityListFile.writeEntityList public #5282
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very small PR to make the
EntityListFile.writeEntityList()
method public. This is a possible first step to merging the entity read/write methods across MM/MHQ. I also need it in the more immediate term to fix problems with BotForce in MekHQ which does not properly read in all of the new deployment information for entities. I could add that deployment information to the MHQ reader/writer but it looks like we are trying to move away from that as I note from the comments at the top ofMHQXMLUtility.writeEntityToXmlString
, which read:I already have a code change in place for MHQ to fix this problem from the MHQ side, but this method needs to be public first.