Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make EntityListFile.writeEntityList public #5282

Merged

Conversation

AaronGullickson
Copy link
Member

This is a very small PR to make the EntityListFile.writeEntityList() method public. This is a possible first step to merging the entity read/write methods across MM/MHQ. I also need it in the more immediate term to fix problems with BotForce in MekHQ which does not properly read in all of the new deployment information for entities. I could add that deployment information to the MHQ reader/writer but it looks like we are trying to move away from that as I note from the comments at the top of MHQXMLUtility.writeEntityToXmlString, which read:

* TODO : This is dumb and we should just use EntityListFile.writeEntityList.
* TODO : Some of this may want to be back-ported into entity itself in MM and then
* TODO : re-factored out of EntityListFile.

I already have a code change in place for MHQ to fix this problem from the MHQ side, but this method needs to be public first.

@HammerGS
Copy link
Member

With the Todo's would this be a draft?

@AaronGullickson
Copy link
Member Author

Nope, not a draft. I am not volunteering yet to do the whole refactoring. But this should allow me to fix the problem in BotForce, where botForces can get all the nice deployment goodies.

@AaronGullickson AaronGullickson merged commit f4765b6 into MegaMek:master Mar 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants