This repository has been archived by the owner on Feb 1, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Add multiple collections #90
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
7600a0e
added Adapter class to handle list of collection
simone-kalbermatter 3b1bc35
add new collection works
simone-kalbermatter 3a4e4db
list of collections is scrollable
simone-kalbermatter 7ecd7f9
bottom bar does not cover collections
simone-kalbermatter a99b87d
added padding
simone-kalbermatter 3985dba
fixed Friends button position
simone-kalbermatter f8bddf1
fix bottom bar covering view (this time really pls)
simone-kalbermatter 56c1ec9
Fix collection having only one element
MeKHell 29aa90a
changed button
simone-kalbermatter 7ec8020
changed name to CollectionListAdapter
simone-kalbermatter 6e9ccdb
add dialog to enter collection name
simone-kalbermatter bbfe441
refactored and handle empty and duplicate collection names
simone-kalbermatter 77fcf9b
add comments
simone-kalbermatter 1733876
upload to db
simone-kalbermatter 2d00ab1
add callback to main
simone-kalbermatter 4cf4927
update DB
simone-kalbermatter 4599914
update comments
simone-kalbermatter 38e6698
add tests
simone-kalbermatter 35d9737
remove xml
simone-kalbermatter 05bafeb
address mariem's comments
simone-kalbermatter 0b91215
refactor tests
simone-kalbermatter 34feda1
use db emulator
simone-kalbermatter 5b5ecd2
fix bug
simone-kalbermatter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is valid for all the tests: Are you updating the collections in the database in the code that you're testing here ? If so, you could use the emulator in this class like in the DatabaseTests classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code storing the collection in the database will be run, however these tests don't verify the upload to the database but only the ProfileFragment UI. The database functions should probably be tested outside of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The database functions are already tested in another class but we should still use the emulator to avoid spamming the "production" database with test values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I just start the database emulator before testing it won't upload to the actual database? Even if it is not in a database test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you can just copy the setup method from the database tests (just the part where you use the emulator ofc).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay thanks, done!