This repository has been archived by the owner on Feb 1, 2025. It is now read-only.
Update media to provide image #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariemBaccari
suggested changes
Mar 16, 2023
app/src/main/java/com/github/sdp/mediato/api/themoviedb/models/TMDBMovie.java
Outdated
Show resolved
Hide resolved
MariemBaccari
suggested changes
Mar 18, 2023
app/src/main/java/com/github/sdp/mediato/model/media/Media.java
Outdated
Show resolved
Hide resolved
app/src/test/java/com/github/sdp/mediato/api/themoviedb/TMDBApiTest.java
Show resolved
Hide resolved
app/src/test/java/com/github/sdp/mediato/api/themoviedb/TMDBApiTest.java
Show resolved
Hide resolved
|
Code Climate has analyzed commit 08c4801 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 73.5% (80% is the threshold). This pull request will bring the total coverage in the repository to 60.4% (10.6% change). View more on Code Climate. |
MariemBaccari
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
Good job with the viewModel and the adapters ! I'm glad the API is working now. I see you also adressed most of my change requests. As we discussed previously, given the fact that we need to urgently merge, this would be an intermediary PR so we would expect another one that tests the feature more thoroughly and adresses the comment about the tests.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow to directly have the image from the Media class, instead of the url provided until now.