Skip to content
This repository has been archived by the owner on Feb 1, 2025. It is now read-only.

Implement editable profile picture on profile page #36

Merged
merged 5 commits into from
Mar 12, 2023

Conversation

simone-kalbermatter
Copy link
Contributor

@simone-kalbermatter simone-kalbermatter commented Mar 11, 2023

The changes in this PR include:

  • extracted a PhotoPicker class from the CreateProfileFragment class
  • used this class to allow the user to edit their profile picture on the profile page
  • changed the default profile picture to be the same as at profile creation

Profile Page in light mode with default profile picture

Menu to select camera or gallery (on click edit button)

  • The edit button could be moved to indicate more clearly the editing of the profile picture if there are no other elements to edit on the profile page in the future.

Profile after selecting a picture from the gallery

Copy link
Contributor

@MeKHell MeKHell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the code seems good to me. Just two small comments...

@codeclimate
Copy link

codeclimate bot commented Mar 12, 2023

Code Climate has analyzed commit 6d9076f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 35.2% (80% is the threshold).

This pull request will bring the total coverage in the repository to 41.4% (0.6% change).

View more on Code Climate.

@simone-kalbermatter simone-kalbermatter merged commit 241087b into main Mar 12, 2023
@simone-kalbermatter simone-kalbermatter removed the request for review from sgueissa March 12, 2023 19:07
@simone-kalbermatter simone-kalbermatter deleted the editable_profile_page branch March 24, 2023 11:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants