This repository has been archived by the owner on Feb 1, 2025. It is now read-only.
Commenting system logic #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/src/main/java/com/github/sdp/mediato/data/ReviewInteractionDatabase.java
Outdated
Show resolved
Hide resolved
|
Code Climate has analyzed commit 1bf288a and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 95.4% (80% is the threshold). This pull request will bring the total coverage in the repository to 82.3% (0.0% change). View more on Code Climate. |
simone-kalbermatter
suggested changes
May 20, 2023
| * @param tarUsername the username of the user who made the review | ||
| * @param comment the comment | ||
| */ | ||
| public static void commentReview(String tarUsername, Comment comment) { |
There was a problem hiding this comment.
What does tarUsername mean?
There was a problem hiding this comment.
Target username. As specified in the java doc, it's the username of the user that made the review which is being commented (as opposed to refUsername - reference username which is the user that is currently logged in). The terminology is used in other database methods.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.