Skip to content
This repository has been archived by the owner on Feb 1, 2025. It is now read-only.

Profile header displays followers and following count #124

Merged
merged 11 commits into from
Apr 16, 2023

Conversation

simone-kalbermatter
Copy link
Contributor

@simone-kalbermatter simone-kalbermatter commented Apr 14, 2023

This PR changes the profile header:

  • The edit button was moved next to the profile picture and changed to a round edit button, given that it only edits the profile picture anyways.
  • The header now displays a Following and Followers button, with the number of following/follower users.

The fragment to display the Following users already existed, and now appears on click of the Following button.
I added another fragment to display the Followers users, which is very similar to the existing following fragment, but does not display buttons for following or unfollowing the displayed users:

Copy link
Contributor

@MeKHell MeKHell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments. Good job.

@codeclimate
Copy link

codeclimate bot commented Apr 16, 2023

Code Climate has analyzed commit 738f170 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 4

The test coverage on the diff in this pull request is 97.8% (70% is the threshold).

This pull request will bring the total coverage in the repository to 78.8% (0.3% change).

View more on Code Climate.

Copy link
Contributor

@MeKHell MeKHell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job 👍

@simone-kalbermatter simone-kalbermatter merged commit ff30f85 into main Apr 16, 2023
@simone-kalbermatter simone-kalbermatter deleted the profile_header_displays_followers branch April 16, 2023 18:01
This was referenced Apr 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants