This repository has been archived by the owner on Feb 1, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Profile header displays followers and following count #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/src/main/java/com/github/sdp/mediato/ui/viewmodel/MyFollowersViewModel.java
Show resolved
Hide resolved
MeKHell
suggested changes
Apr 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments. Good job.
app/src/main/java/com/github/sdp/mediato/utility/adapters/UserAdapter.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/sdp/mediato/ui/viewmodel/ProfileViewModel.java
Show resolved
Hide resolved
app/src/main/java/com/github/sdp/mediato/ui/viewmodel/MyFollowersViewModel.java
Show resolved
Hide resolved
app/src/main/java/com/github/sdp/mediato/ui/viewmodel/MyFollowingViewModel.java
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/com/github/sdp/mediato/ProfileFragmentTest.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/sdp/mediato/utility/adapters/UserFollowAdapter.java
Show resolved
Hide resolved
app/src/main/java/com/github/sdp/mediato/utility/adapters/UserAdapter.java
Outdated
Show resolved
Hide resolved
Code Climate has analyzed commit 738f170 and detected 4 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 97.8% (70% is the threshold). This pull request will bring the total coverage in the repository to 78.8% (0.3% change). View more on Code Climate. |
MeKHell
approved these changes
Apr 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great job 👍
This was referenced Apr 18, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the profile header:
The fragment to display the Following users already existed, and now appears on click of the Following button.
I added another fragment to display the Followers users, which is very similar to the existing following fragment, but does not display buttons for following or unfollowing the displayed users: