This repository has been archived by the owner on Feb 1, 2025. It is now read-only.
Profile fetching bug #118
Merged
Profile fetching bug #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgueissa
suggested changes
Mar 31, 2023
Comment on lines
+137
to
+175
| /** | ||
| * Adds the default profile image to the user | ||
| * @param username: the user's username | ||
| */ | ||
| private void addDefaultProfilePic(String username) { | ||
| // we need to create a new thread to download the default profile pic, otherwise it will make the app lag | ||
| new Thread(() -> { | ||
| try { | ||
| // the url of the default profile picture | ||
| URL url = new URL(getString(R.string.default_profile_pic)); | ||
|
|
||
| // connect via html to download | ||
| HttpURLConnection connection = (HttpURLConnection) url.openConnection(); | ||
| connection.setDoInput(true); | ||
| connection.connect(); | ||
| InputStream input = connection.getInputStream(); | ||
| Bitmap bitmap = BitmapFactory.decodeStream(input); | ||
|
|
||
| // store the file as a temporary image in the cache | ||
| File cacheDir = requireContext().getCacheDir(); | ||
| File imageFile = File.createTempFile("profile_pic", ".jpg", cacheDir); | ||
| FileOutputStream outputStream = new FileOutputStream(imageFile); | ||
|
|
||
| // get the bitmap out of it, and convert to uri | ||
| bitmap.compress(Bitmap.CompressFormat.JPEG, 100, outputStream); | ||
| outputStream.close(); | ||
| Uri uri = Uri.fromFile(imageFile); | ||
|
|
||
| // we can now store it in the database, and then switch to main activity | ||
| Database.setProfilePic(username, uri).addOnCompleteListener(v -> { | ||
| switchToMainActivity(username); | ||
| makeToast(getString(R.string.profile_creation_success)); | ||
| });; | ||
| } catch (IOException e) { | ||
| throw new RuntimeException("Failed to download and save the default profile pic", e); | ||
| } | ||
| }).start(); | ||
| } | ||
|
|
|
Code Climate has analyzed commit 25cdc5b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 0.0% (70% is the threshold). This pull request will bring the total coverage in the repository to 76.9% (-2.2% change). View more on Code Climate. |
sgueissa
approved these changes
Mar 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the bug by setting a default profile picture from the web to be set for any users that did not choose one.