Manage Workers Task: check active messages #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manthey
approved these changes
Apr 10, 2024
manthey
reviewed
Apr 10, 2024
JakeWags
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
manage_workerstask runs every 20 seconds, it may preemptively stop a GPU worker currently working on a DeepSSM task (which will take longer than 20 seconds). This is because the current implementation only checks the number of messages waiting on the queue. If the worker is currently processing the last requested task, the number of waiting messages will be 0, and with the current implementation, that would mean that the GPU workers should be stopped.This PR adds a check for the number of messages currently active on a worker; workers will only be stopped if the number of active messages is 0.