-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic image view and controls #359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good! Approved 👍
renderer.resetCamera() | ||
}, | ||
updateIntersection(slice) { | ||
// TODO: account for multidomain cases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a plan in place for this? The image slice should be the same regardless of domain number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will need a dataset to use to implement this; I don't currently have a multidomain dataset where the original data are images. The slices will be the same, but there would be n
shapes to intersect and n
particles objects to filter.
This PR adds the image view mode, which will be used by default for rendering any vtkImageData. Previously, we used an imageMarchingCubes filter to turn vtkImageData into vtkPolyData, which could take a while to compute.
The image view mode includes the following basic controls/features:
When the "Groomed" layer is enabled:
When the "Particles" layer is enabled and Intersection mode is enabled:
The following video demonstrates each of these features (speed 2x).
https://github.com/girder/shapeworks-cloud/assets/44912689/ba9d7b60-f56b-4ef2-b4df-51953d92880d