-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Landmark edits #340
Landmark edits #340
Conversation
609f8e0
to
9fab142
Compare
7b2f8a5
to
ff64731
Compare
1ff41d8
to
0cd5736
Compare
I'm getting this error when attempting to save landmarks after setting them for each subject:
Here is the request info:
|
Client test is failing for a reason that is outside the scope of this PR: #351. |
I noticed an error that is manifesting in two ways: The error:
Both revolve around selecting a subject, and then placing the landmark on a different subject. For example: If I select LA_01 and then place the landmark on LA_04, the TypeError is thrown. Here are the two cases I found:
Both of these revolve around placing a landmark on a subject OTHER than the one initially selected. This kind of interaction seems counter intuitive, as the user has to select which subject they will place the landmark on. |
Closing in favor of #355. In working on Constraints, I have needed to refactor Landmarks and change the storage & retrieval mechanisms a considerable amount. Also, the vtk.js bug fixes will be done on top of the changes for both features. The changes for the two features should be reviewed as one. |
This PR adds functionality to edit landmarks. Depends on #336.
shapeworks_editing_landmarks.mp4