Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustable analysis parameters #329

Merged
merged 12 commits into from
Jul 27, 2023
Merged

Adjustable analysis parameters #329

merged 12 commits into from
Jul 27, 2023

Conversation

JakeWags
Copy link
Collaborator

@JakeWags JakeWags commented Jul 19, 2023

This PR adds the ability for users to adjust the analysis parameters for the PCA std. deviation.

This adds an analyze task for spawning an analysis job as well as accompanying methods, endpoints, etc.
The default range and steps are 2.0 and 11 respectively. After much discussion with Alan, we decided that the analysis should simply rerun anytime the steps or range is altered.

analysis_params

Additionally, run_shapeworks_command now includes an optional args parameter which is a List[str] of the arguments (i.e. "--range 2.0")

Also included:

  • Rounding of analysis calculated numbers to 2 decimal places
  • Pydantic v2.3 update (needs discussion)

Required:

  • discuss pydantic update to v2.3 and either fully upgrade or stay in v1.10.11 (can be separate pr)

@JakeWags JakeWags requested a review from annehaley July 19, 2023 16:31
Copy link
Collaborator

@annehaley annehaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things I noticed.

web/shapeworks/src/components/Analysis/PCA.vue Outdated Show resolved Hide resolved
web/shapeworks/src/api/rest.ts Outdated Show resolved Hide resolved
web/shapeworks/src/store/methods.ts Outdated Show resolved Hide resolved
@annehaley annehaley force-pushed the analysis-parameters branch from eef03c8 to f3c27c9 Compare July 24, 2023 15:21
web/shapeworks/src/api/rest.ts Outdated Show resolved Hide resolved
web/shapeworks/src/components/Analysis/PCA.vue Outdated Show resolved Hide resolved
@JakeWags JakeWags merged commit 9c067c8 into master Jul 27, 2023
@JakeWags JakeWags deleted the analysis-parameters branch July 27, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants