Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support verbose output of the test suites #985

Merged
merged 1 commit into from
Jan 26, 2018

Conversation

RonEld
Copy link
Contributor

@RonEld RonEld commented Jun 25, 2017

generate add ctest test-suites, with the --verbose argument to be given
to the test suites.
The verbose output will be shown only if ctest is run with -v parameter
The verbose argument is to the test-suites, only when run through ctest

generate add ctest test-suites, with the --verbose argument to be given
to the test suites.
The verbose output will be shown **only** if ctest is run with `-v` parameter
The verbose argument is to the test-suites, only when run through `ctest`
@andresag01
Copy link
Contributor

This PR is related to #981.

Copy link

@hanno-becker hanno-becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the change, too. The only thing I noticed is that now make test using the shipped makefiles differs from make test using CMake-generated makefiles: In the shipped makefiles, make test leads to ./tests/scripts/run-test-suites.pl being executed, calling the test suites without the --verbose argument, while for the CMake generated ones, ctest is called, which now uses --verbose.

@RonEld
Copy link
Contributor Author

RonEld commented Aug 15, 2017

Hi @hanno-arm
Thanks for your comment. Actually, even when running the ctests, you will not see the output, unless you run the ctest with -V or -VV parameter. This PR is to support -V parameter for ctest , that will actually verbose the test_suites. Perhaps we should modify ./tests/scripts/run-test-suites.pl to support running the tests with verbose, but I don't think it's really needed, at the time being

@simonbutcher simonbutcher added approved Design and code approved - may be waiting for CI or backports and removed needs-design-approval labels Jan 24, 2018
@Patater Patater merged commit f361248 into Mbed-TLS:development Jan 26, 2018
daverodgman added a commit that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Design and code approved - may be waiting for CI or backports enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants