Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Changelog for Arm compile fix #6752

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Add Changelog for Arm compile fix #6752

merged 1 commit into from
Dec 8, 2022

Conversation

daverodgman
Copy link
Contributor

Add missing Changelog entry for #6090

@daverodgman
Add Changelog for Arm compile fix
b74aa5a 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
@daverodgman daverodgman added bug needs-review Every commit must be reviewed by at least two team members, component-platform Portability layer and build scripts needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d) single-reviewer This PR qualifies for having only one reviewer priority-high High priority - will be reviewed soon labels Dec 8, 2022
@tom-daubney-arm tom-daubney-arm self-requested a review December 8, 2022 13:52
@tom-daubney-arm tom-daubney-arm removed the needs-reviewer This PR needs someone to pick it up for review label Dec 8, 2022
tom-daubney-arm
tom-daubney-arm approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@tom-daubney-arm tom-daubney-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a spelling error in the filename (erorr, rather than error) but I suspect this has no consequence once the Changelog has been generated. No typos in main body of text and hence approved.

@tom-daubney-arm tom-daubney-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Dec 8, 2022
yanesca
yanesca approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Checked that these issues have been fixed and I couldn't see any existing entry for them)

@daverodgman daverodgman merged commit a6ca882 into Mbed-TLS:development Dec 8, 2022
@daverodgman daverodgman deleted the arm-build-changelog branch December 8, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-daubney-arm tom-daubney-arm tom-daubney-arm approved these changes

@yanesca yanesca yanesca approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports bug component-platform Portability layer and build scripts priority-high High priority - will be reviewed soon single-reviewer This PR qualifies for having only one reviewer size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daverodgman @yanesca @tom-daubney-arm