Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLS 1.3: EarlyData SRV: Write early data extension in EncryptedExtension #6720

Merged
merged 10 commits into from
Nov 7, 2023
Merged

TLS 1.3: EarlyData SRV: Write early data extension in EncryptedExtension #6720

merged 10 commits into from
Nov 7, 2023

Conversation

yuhaoth
Copy link
Contributor

@yuhaoth yuhaoth commented Dec 5, 2022 •
edited
Loading

Description

fix #6338

preceding: #6719

Gatekeeper checklist

  • changelog provided, or not required
  • backport done, or not required
  • tests provided, or not required

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

@yuhaoth yuhaoth changed the title TLS 1.3: EarlyData SRV: TLS 1.3: EarlyData SRV: Add writer of early data extension and parser of 0-RTT data/EOED. Dec 5, 2022
@yuhaoth yuhaoth mentioned this pull request Dec 5, 2022
Merged
3 tasks
@yuhaoth yuhaoth added needs-review Every commit must be reviewed by at least two team members, needs-preceding-pr Requires another PR to be merged first needs-reviewer This PR needs someone to pick it up for review component-tls13 labels Dec 5, 2022
@yuhaoth yuhaoth added the priority-high High priority - will be reviewed soon label Dec 5, 2022
@yuhaoth yuhaoth force-pushed the pr/tls13-early-data-receive-0_rtt-and-eoed branch 6 times, most recently from c5b4b27 to 4a0d91b Compare December 8, 2022 03:44
@yuhaoth yuhaoth force-pushed the pr/tls13-early-data-receive-0_rtt-and-eoed branch 4 times, most recently from 58e8785 to a0edd60 Compare December 17, 2022 03:08
@yuhaoth yuhaoth force-pushed the pr/tls13-early-data-receive-0_rtt-and-eoed branch from a0edd60 to 570a1e6 Compare December 30, 2022 03:36
@yuhaoth yuhaoth mentioned this pull request Jan 4, 2023
Merged
5 tasks
@yuhaoth yuhaoth force-pushed the pr/tls13-early-data-receive-0_rtt-and-eoed branch 2 times, most recently from ef2573e to 70c1f7b Compare January 5, 2023 02:51
@yuhaoth yuhaoth force-pushed the pr/tls13-early-data-receive-0_rtt-and-eoed branch from 70c1f7b to 2ecbd3a Compare January 12, 2023 09:45
@yuhaoth yuhaoth force-pushed the pr/tls13-early-data-receive-0_rtt-and-eoed branch 4 times, most recently from aa8ee22 to 4889322 Compare February 8, 2023 07:10
@yuhaoth yuhaoth mentioned this pull request Feb 8, 2023
Merged
3 tasks
@yuhaoth yuhaoth changed the title TLS 1.3: EarlyData SRV: Add writer of early data extension and parser of 0-RTT data/EOED. TLS 1.3: EarlyData SRV: Write early data extension in EncryptedExtension Feb 8, 2023
@yuhaoth yuhaoth added priority-high High priority - will be reviewed soon and removed priority-medium Medium priority - this can be reviewed as time permits labels Oct 12, 2023
@yuhaoth
tls13: add more checks for server early data
985c967 
- check if it is enabled
- check if it is psk mode
- check if it is resumption
- check if it is tls13 version

Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
@yuhaoth
write early data indication in EE msg
71c14f1 
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
@yuhaoth
Add test case for writing early data in EE
0edafa9 
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
@yuhaoth
disable tests when ecp is not available
2db16b7 
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
@yuhaoth yuhaoth force-pushed the pr/tls13-early-data-receive-0_rtt-and-eoed branch from 7638f1c to 2db16b7 Compare October 27, 2023 02:59
@yuhaoth yuhaoth removed needs-preceding-pr Requires another PR to be merged first needs-reviewer This PR needs someone to pick it up for review labels Oct 27, 2023
ronald-cron-arm
ronald-cron-arm requested changes Oct 30, 2023
View reviewed changes
@yuhaoth yuhaoth force-pushed the pr/tls13-early-data-receive-0_rtt-and-eoed branch from 5f1c1a7 to e164d4d Compare October 31, 2023 09:06
@yuhaoth
fix various issues
454dda3 
- improve output message
- Remove unnecessary checks
- Simplify test command

Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
@yuhaoth
move ticket version check
ce3b95e 
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
@yuhaoth
Add selected key and ciphersuite check
82fd6c1 
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
@yuhaoth
move psk check to EE message on client side
960b7eb 
early_data extension is sent in EE. So it should
not be checked in SH message.

Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
@yuhaoth yuhaoth force-pushed the pr/tls13-early-data-receive-0_rtt-and-eoed branch from be4badd to 960b7eb Compare November 1, 2023 02:32
ronald-cron-arm
ronald-cron-arm requested changes Nov 6, 2023
View reviewed changes
@yuhaoth
check the ticket version unconditional
2bea94c 
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
@yuhaoth
fix various issues
7ef9fd8 
- Debug message
- Improve comments

Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
@yuhaoth yuhaoth force-pushed the pr/tls13-early-data-receive-0_rtt-and-eoed branch from 6bb317f to 7ef9fd8 Compare November 7, 2023 06:31
ronald-cron-arm
ronald-cron-arm approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

xkqian
xkqian approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@xkqian xkqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xkqian
Copy link
Contributor

xkqian commented Nov 7, 2023

Seems The CI isn't happy, but isn't related with PR.

@xkqian xkqian added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Nov 7, 2023
@tom-cosgrove-arm tom-cosgrove-arm added this pull request to the merge queue Nov 7, 2023
Merged via the queue into Mbed-TLS:development with commit 53199b1 Nov 7, 2023
@yuhaoth yuhaoth deleted the pr/tls13-early-data-receive-0_rtt-and-eoed branch November 8, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronald-cron-arm ronald-cron-arm ronald-cron-arm approved these changes

@xkqian xkqian xkqian approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports component-tls13 priority-high High priority - will be reviewed soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TLS 1.3 server: Writing of the early data indication extension
5 participants
@yuhaoth @xkqian @ronald-cron-arm @daverodgman @tom-cosgrove-arm