TLS 1.3: Refactor early data configuration interface. #6537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8786ba1 to
1bc6ea2
Compare
5 tasks
408eccd to
60647a6
Compare
60647a6 to
f5d4b3b
Compare
f5d4b3b to
a392b0a
Compare
|
Seems some conflict files, would you rebase it firstly? |
a392b0a to
4f66b6e
Compare
|
OpenCI interrupt some test cases and raise channel unavailable. NOT code relative fail. |
a473fc0 to
fa24cc4
Compare
xkqian
suggested changes
Nov 22, 2022
ronald-cron-arm
requested changes
Dec 5, 2022
- disable reuse of max_early_data_size. - make conf_early_data available for server. - various comment issues Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
This reverts commit a693477. Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
2a248f3 to
3a8c593
Compare
3a8c593 to
0ad50d2
Compare
`conf_max_early_data_size` does not reuse as en/disable. When call it, we should call `conf_early_data()` also. Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
0ad50d2 to
d146a37
Compare
ronald-cron-arm
requested changes
Dec 6, 2022
Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
- early_data default to disable - max_early_data_size default to built-in value Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
18415e8 to
6ee56aa
Compare
ronald-cron-arm
approved these changes
Dec 6, 2022
xkqian
reviewed
Dec 7, 2022
| @@ -129,6 +129,7 @@ int main( void ) | |||
| #define DFL_SNI NULL | |||
| #define DFL_ALPN_STRING NULL | |||
| #define DFL_CURVES NULL | |||
| #define DFL_MAX_EARLY_DATA_SIZE 0 | |||
There was a problem hiding this comment.
See line 430, Should it be -1?
There was a problem hiding this comment.
The argument max_early_data_size is reused for disable/enable , that's different with conf->max_early_data_size and opt.max_early_data_size.
I add tls13_early_data_enabled to represent disable/enabled and opt.max_early_data_size is same meaning with conf->max_early_data_size. So here should be 0
| else if( strcmp( p, "max_early_data_size" ) == 0 ) | ||
| { | ||
| long long value = atoll( q ); | ||
| tls13_early_data_enabled = |
There was a problem hiding this comment.
A common question, in server side, it seems we check the max_early_data_size to decide whether we enable early data or not, is that what we need?
There was a problem hiding this comment.
No, this point has been changed. mbetls_ssl_tls13_conf_early_data is available for server also now.
|
OpenCI cancel all tests without reason. Internal CI and travisCI pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #6338 ,
fix #6347
preceding #6621
mbedtls_ssl_tls13_conf_max_early_data_size.Gatekeeper checklist
Notes for the submitter
Please refer to the contributing guidelines, especially the
checklist for PR contributors.