Set CMake Max Version #3691
Merged
Set CMake Max Version #3691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fb75e89 to
9464f51
Compare
ronald-cron-arm
requested changes
Oct 1, 2020
9464f51 to
7a55b22
Compare
d3zd3z
previously approved these changes
Oct 26, 2020
7a55b22 to
3b3a2e2
Compare
d3zd3z
previously approved these changes
Oct 27, 2020
CMakeLists.txt
Outdated
| @@ -17,6 +17,15 @@ | |||
| # | |||
|
|
|||
| cmake_minimum_required(VERSION 2.8.12) | |||
|
|
|||
| # https://cmake.org/cmake/help/latest/policy/CMP0011.html | |||
| # Fix warnings in CMake >= 3.18.0. OLD is deprecated. | |||
There was a problem hiding this comment.
"OLD is deprecated."
From your comment below:
"This is necessary to avoid a warning when using any FindPython* on cmake > 3.18. The warning indicates this policy has to be set one way or the other, having it set to default is deprecated."
it seems that what is deprecated is "not setting the policy", not that OLD is deprecated.
From the commit message it seems both are deprecated.
Thus I'm confused. Could you clarify the comment ?
There was a problem hiding this comment.
The issue here is that that it is basically both. If its not set, then a warning is generated, and the OLD behaviour is used. The OLD behaviour is deprecated by definition, and may be removed in a future version of CMake, thus the only sensible thing to set it to is NEW. This is all detailed in the link, so I didn't want a massive comment, but will try and make it more clear.
CMakeLists.txt
Outdated
| # Fix warnings in CMake >= 3.18.0. OLD is deprecated. | ||
| cmake_policy(SET CMP0011 NEW) | ||
| # https://cmake.org/cmake/help/latest/policy/CMP0012.html | ||
| # We require this for FindPython3 to work with CMake 3.18.2, but this will also generate warnings in |
There was a problem hiding this comment.
What about:
"Setting the CMP0012 policy to NEW is required for FindPython3 to work with CMake 3.18.2 (bug in this particular version).
Otherwise, setting the CMP0012 policy is required for CMake versions >= 3.18.3 and a warning is generated if it is not the case."
Again, I am not completely sure about what is actually deprecated: not setting the policy or the OLD value of the policy, both ?
There was a problem hiding this comment.
Again, its both.
Make sure that CMP0012 is set to NEW, without which FindPython3 and FindPython2 functionality becomes broken with CMake 3.18.2 if searching by location. CMP0012 being set to OLD is also deprecated as of 3.18.3. Ensure CMP0011 is set to NEW to avoid warnings and deprecated behaviour being issued about policy push / pop with CMake 3.18.0 or newer. Signed-off-by: Paul Elliott <paul.elliott@arm.com>
3b3a2e2 to
b250ac9
Compare
mpg
approved these changes
Dec 8, 2020
There was a problem hiding this comment.
Looks good to me.
Thanks for adding comments as requested by Ronald. I think the comments don't really need more details than their current version, considering they include links to the official CMake documentation which has all the details (and hopefully will be kept up-to-date).
ronald-cron-arm
approved these changes
Dec 17, 2020
Sacha0
added a commit
to JuliaLang/julia
that referenced
this pull request
Dec 17, 2020
MBedTLS fails to build with CMake 3.18.2, due to a bug in CMake 3.18.2 causing failure to find python3. For more information, please see Mbed-TLS/mbedtls#3690 and https://gitlab.kitware.com/cmake/cmake/-/issues/21204. This pull request applies the MBedTLS patch that works around this issue from Mbed-TLS/mbedtls#3691, which has been merged into MBedTLS's development branch but not yet into a tagged release.
Sacha0
added a commit
to JuliaLang/julia
that referenced
this pull request
Dec 17, 2020
MBedTLS fails to build with CMake 3.18.2, due to a bug in CMake 3.18.2 causing failure to find python3. For more information, please see Mbed-TLS/mbedtls#3690 and https://gitlab.kitware.com/cmake/cmake/-/issues/21204. This pull request applies the MBedTLS patch that works around this issue from Mbed-TLS/mbedtls#3691, which has been merged into MBedTLS's development branch but not yet into a tagged release.
Sacha0
added a commit
to JuliaLang/julia
that referenced
this pull request
Dec 21, 2020
MBedTLS fails to build with CMake 3.18.2, due to a bug in CMake 3.18.2 causing failure to find python3. For more information, please see Mbed-TLS/mbedtls#3690 and https://gitlab.kitware.com/cmake/cmake/-/issues/21204. This pull request applies the MBedTLS patch that works around this issue from Mbed-TLS/mbedtls#3691, which has been merged into MBedTLS's development branch but not yet into a tagged release. The latest minor release as of that merge was 2.25.0, so it's probably safe to conjecture that this patch will be live as of minor release 2.26.0; it's also possible that this patch will land on patch releases for 2.24.0 and 2.25.0, but this author doesn't know.
Sacha0
added a commit
to JuliaLang/julia
that referenced
this pull request
Dec 21, 2020
MBedTLS fails to build with CMake 3.18.2, due to a bug in CMake 3.18.2 causing failure to find python3. For more information, please see Mbed-TLS/mbedtls#3690 and https://gitlab.kitware.com/cmake/cmake/-/issues/21204. This pull request applies the MBedTLS patch that works around this issue from Mbed-TLS/mbedtls#3691, which has been merged into MBedTLS's development branch but not yet into a tagged release. The latest minor release as of that merge was 2.25.0, so it's probably safe to conjecture that this patch will be live as of minor release 2.26.0; it's also possible that this patch will land on patch releases for 2.24.0 and 2.25.0, but this author doesn't know.
staticfloat
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Dec 21, 2020
MBedTLS fails to build with CMake 3.18.2, due to a bug in CMake 3.18.2 causing failure to find python3. For more information, please see Mbed-TLS/mbedtls#3690 and https://gitlab.kitware.com/cmake/cmake/-/issues/21204. This pull request applies the MBedTLS patch that works around this issue from Mbed-TLS/mbedtls#3691, which has been merged into MBedTLS's development branch but not yet into a tagged release. The latest minor release as of that merge was 2.25.0, so it's probably safe to conjecture that this patch will be live as of minor release 2.26.0; it's also possible that this patch will land on patch releases for 2.24.0 and 2.25.0, but this author doesn't know.
Sacha0
added a commit
to JuliaLang/julia
that referenced
this pull request
Dec 22, 2020
MBedTLS fails to build with CMake 3.18.2, due to a bug in CMake 3.18.2 causing failure to find python3. For more information, please see Mbed-TLS/mbedtls#3690 and https://gitlab.kitware.com/cmake/cmake/-/issues/21204. This pull request applies the MBedTLS patch that works around this issue from Mbed-TLS/mbedtls#3691, which has been merged into MBedTLS's development branch but not yet into a tagged release. The latest minor release as of that merge was 2.25.0, so it's probably safe to conjecture that this patch will be live as of minor release 2.26.0; it's also possible that this patch will land on patch releases for 2.24.0 and 2.25.0, but this author doesn't know.
KristofferC
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Dec 25, 2020
) MBedTLS fails to build with CMake 3.18.2, due to a bug in CMake 3.18.2 causing failure to find python3. For more information, please see Mbed-TLS/mbedtls#3690 and https://gitlab.kitware.com/cmake/cmake/-/issues/21204. This pull request applies the MBedTLS patch that works around this issue from Mbed-TLS/mbedtls#3691, which has been merged into MBedTLS's development branch but not yet into a tagged release. The latest minor release as of that merge was 2.25.0, so it's probably safe to conjecture that this patch will be live as of minor release 2.26.0; it's also possible that this patch will land on patch releases for 2.24.0 and 2.25.0, but this author doesn't know.
staticfloat
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Jan 15, 2021
) MBedTLS fails to build with CMake 3.18.2, due to a bug in CMake 3.18.2 causing failure to find python3. For more information, please see Mbed-TLS/mbedtls#3690 and https://gitlab.kitware.com/cmake/cmake/-/issues/21204. This pull request applies the MBedTLS patch that works around this issue from Mbed-TLS/mbedtls#3691, which has been merged into MBedTLS's development branch but not yet into a tagged release. The latest minor release as of that merge was 2.25.0, so it's probably safe to conjecture that this patch will be live as of minor release 2.26.0; it's also possible that this patch will land on patch releases for 2.24.0 and 2.25.0, but this author doesn't know.
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
) MBedTLS fails to build with CMake 3.18.2, due to a bug in CMake 3.18.2 causing failure to find python3. For more information, please see Mbed-TLS/mbedtls#3690 and https://gitlab.kitware.com/cmake/cmake/-/issues/21204. This pull request applies the MBedTLS patch that works around this issue from Mbed-TLS/mbedtls#3691, which has been merged into MBedTLS's development branch but not yet into a tagged release. The latest minor release as of that merge was 2.25.0, so it's probably safe to conjecture that this patch will be live as of minor release 2.26.0; it's also possible that this patch will land on patch releases for 2.24.0 and 2.25.0, but this author doesn't know.
staticfloat
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Dec 23, 2022
) MBedTLS fails to build with CMake 3.18.2, due to a bug in CMake 3.18.2 causing failure to find python3. For more information, please see Mbed-TLS/mbedtls#3690 and https://gitlab.kitware.com/cmake/cmake/-/issues/21204. This pull request applies the MBedTLS patch that works around this issue from Mbed-TLS/mbedtls#3691, which has been merged into MBedTLS's development branch but not yet into a tagged release. The latest minor release as of that merge was 2.25.0, so it's probably safe to conjecture that this patch will be live as of minor release 2.26.0; it's also possible that this patch will land on patch releases for 2.24.0 and 2.25.0, but this author doesn't know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure that CMake policy CMP0012 is set to NEW, without which FindPython3 and FindPython2 functionality becomes broken with CMake 3.18.2 if searching by location. This will be fixed in CMake 3.18.3, however this policy will remain the default, so this is a safe change. Ensure CMP0011 is set to NEW to avoid warnings being issued about policy push / pop with CMake 3.18.0 or newer.
This closes #3690
Status
READY
Requires Backporting
No (Newer version of FindPython3 not used in either LTS branch)
Todos
Steps to test or reproduce
Project should now build with CMake version 3.18.2, which it won't without this patch.